Fix response parsing

package.json

@@ -51,6 +51,7 @@
     "prepare": "simple-git-hooks"
   },
   "dependencies": {
+    "cheerio": "1.0.0-rc.12",
     "ky": "^1.2.4",
     "undici": "^6.15.0",
     "xml-js": "^1.6.11"

src/errors.ts

@@ -3,7 +3,7 @@ export enum ErrorCode {
   InvalidCredentials = 'INVALID_CREDENTIALS',
   InvalidFaxNumber = 'INVALID_FAX_NUMBER',
   InsufficientBalance = 'INSUFFICIENT_BALANCE',
-  InvalidDocument = 'INVALID_DOCUMENT',
+  FaultyDocument = 'FAULTY_DOCUMENT',
   InternalError = 'INTERNAL_ERROR',
   Other = 'OTHER',
 }
@@ -28,7 +28,7 @@ export class SimpleFaxError extends Error {
         break
 
       case 'Dokument fehlerhaft':
-        this.code = ErrorCode.InsufficientBalance
+        this.code = ErrorCode.FaultyDocument
         break
 
       default:

src/index.ts

@@ -1,7 +1,6 @@
 import { js2xml } from 'xml-js'
-import type { Options } from 'ky'
-import ky from 'ky'
 import { request } from 'undici'
+import * as cheerio from 'cheerio'
 import { SimpleFaxError } from './errors.js'
 import type { EnvelopeOptions } from './types.js'
 import template from './template.json'
@@ -38,16 +37,20 @@ export async function sendFax(
 ): Promise<string> {
   const envelope = createEnvelope(options)
 
-  const response = await request('http://longisland.simple-fax.de/soap/index.php', {
+  const xml = await request('https://longisland.simple-fax.de/soap/index.php', {
+    method: 'POST',
     body: envelope,
     headers: {
       'Content-Type': 'text/xml;charset=UTF-8',
       'SOAPAction': `"urn:soapservice#Service#sendfax"`,
     },
   }).then(({ body }) => body.text())
 
+  const $ = cheerio.load(xml)
+  const response = $('ns4\\:sendfaxResponse').text()
+
   // Response format: "status;message."
-  const [status, message] = response.trim().replace(/\.$/, '').split(';')
+  const [status, message] = response.trim().replace(/\..*$/, '').split(';')
 
   if (status === 'success')
     return message

src/types.d.ts

@@ -29,9 +29,14 @@ export interface EnvelopeOptions {
    * Callback URL
    *
    * After transmission, a `GET` request with the following parameters is sent to the callback URL:
-   * - `faxid`
+   * - `faxid` (internal suid rather than the fax ID displayed in the "Versandbox")
    * - `status` (either "done" or "failed")
    * - `reason` (error message)
+   * - `timestamp` (unix timestamp in seconds)
+   * - `totpages` (number of pages)
+   * - `tsi` (unknown parameter)
+   * - `number` (recipient fax number)
+   * - `price` (price in `-x.xx` format)
    */
   statusurl: string
 }