Add [[nodiscard]] attribute to C++ headers that return values, such as operators [Jazzy]

[Ryanf55]

Feature request

Feature description

Getters and operators could have the [[nodiscard]] attribute to prevent bugs.

Implementation considerations

See /opt/ros/humble/include/geometry_msgs/geometry_msgs/msg/detail/point__struct.hpp. This is ABI breaking because it increases the strictness of the API.

Before:

  bool operator!=(const Point_ & other) const
  {
    return !this->operator==(other);
  }
  

Proposed:

  [[nodiscard]] bool operator!=(const Point_ & other) const
  {
    return !this->operator==(other);
  }

Effect:

Using the != operator without assigning the value would then issue a compile warning.

Related

Same as gazebosim/sdformat#1358

[wjwwood]

Reviewing from our issue triaging meeting, sounds like a nice improvement, help is appreciated.

[jmachowinski]

Is this issue fixed and can be closed ?

[clalancette]

It looks like it, thanks. I'll go ahead and close it.