ros2action: add SIGINT handler to manage cancel request. #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
commented
Dec 20, 2024
There was a problem hiding this comment.
this fixes the problem described in ros2/rclpy#1390 (comment)
root@tomoyafujita:~/ros2_ws/colcon_ws# ros2 action send_goal /fibonacci example_interfaces/action/Fibonacci "{order: 10}"
Waiting for an action server to become available...
Sending goal:
order: 10
Goal accepted with ID: 64f5bdaf913348e98ef2180881c6fa68
^CCanceling goal...
Goal canceled.
Result:
sequence: []
Goal finished with status: CANCELEDNo exception generated, and correct status returned.
|
@clalancette @ahcorde can you take a look when you have time? if you think of any better solution, please let me know. |
sea-bass
reviewed
Dec 20, 2024
|
Pulls: #956
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ros2/rclpy#1390