Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2] link image_transport #59

Open
wodtko opened this issue Jan 3, 2022 · 2 comments
Open

[ros2] link image_transport #59

wodtko opened this issue Jan 3, 2022 · 2 comments

Comments

@wodtko
Copy link

wodtko commented Jan 3, 2022

the ros2 feature branch of the image_transport package now creates a modern CMake target instead of setting _INCLUDE_DIRS and _LIBRARIES variables.
Thus, the include of image_transport/image_transport.h fails during the build.

I would suggest creating a new branch, something like rolling-devel or similar, since changes like this might come for other dependency packages.
The respective CMake fix is rather small. (link against new target image_transport::image_transport, or ${image_transport}_TARGETS)

@wodtko
Copy link
Author

wodtko commented Jan 3, 2022

a respective fix is available at (https://github.com/wodtko/rqt_image_view/tree/rolling-devel) not sure about the new branch tho.
linking ${image_transport}_TARGETS would, in general, link all targets of the package, but the only dependency is image_transport::image_transport, which is why I only added this specific target.

@RFRIEDM-Trimble
Copy link

FYI, with this PR, you can now consume the alias targets.
ros-perception/image_common@2edae7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants