Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for passing a colcon defaults.yaml file #195

Closed
thomas-moulard opened this issue May 4, 2020 · 1 comment
Closed

Add support for passing a colcon defaults.yaml file #195

thomas-moulard opened this issue May 4, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@thomas-moulard
Copy link
Member

thomas-moulard commented May 4, 2020 •
edited
Loading

Description

colcon behavior can be modified by passing a defaults.yaml file (see doc).

Related Issues

TBD

Completion Criteria

  • I can specify a defaults.yaml file when running my workflow
  • I can specify a URL as a default.yaml file when running my workflow

Implementation Notes / Suggestions

Add an action input colcon-default-urls which defaults to an empty value. If non-empty, the file should be downloaded (if necessary) and passed to colcon. This would remove the need for the action to continue expending its interface to cover each flag that the users may want to pass to colcon.

Testing Notes / Suggestions

Additional workflows passing local and remote defaults file must be added.
@thomas-moulard thomas-moulard added the enhancement New feature or request label May 4, 2020
@thomas-moulard
Copy link
Member Author

thomas-moulard commented May 4, 2020 •
edited by emersonknapp
Loading

Closing in favor of #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomas-moulard