Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS Conventions #38

Open
reinzor opened this issue Feb 19, 2017 · 3 comments
Open

ROS Conventions #38

reinzor opened this issue Feb 19, 2017 · 3 comments

Comments

@reinzor
Copy link

reinzor commented Feb 19, 2017

Currently, the ROS naming conventions are not met within the ros packages / nodes / configurations of pepper:

I could send a PR to fix this, would you be interested?

@Karsten1987
Copy link
Contributor

Thanks for bringing this up. As of TF, we're aware of this, but the URDF files are mostly generated and comply with the internal libqi/naoqi conventions.
AFAIK, the same rule applies for topic names.

@reinzor
Copy link
Author

reinzor commented Mar 2, 2017

Can't we add a post_script after the auto_generation that transforms camelcases to lowercase underscore?

@victorpaleologue
Copy link
Contributor

It's doable, but wouldn't that break existing code?
Unless we publish them in another topic...
And then we have to document how to switch from one to the other.
It's a bit annoying.

Can we compare that to the consequences of not renaming?
What would be wrong if we kept these names this way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants