Official ROS docker images do not ship compilers anymore

[mathias-luedtke]

This breaks most ROS_REPO=ros builds. See #514 as well.

[gavanderhoorn]

According to @ruffsl in ROS Noetic Ninjemys Release:

Building tools (rosdep, compilers, git, rosinstall etc) are now in ros:noetic-ros-base and not part of the ros-core image anymore

[mathias-luedtke]

@gavanderhoorn: Thanks for pointing this out! Mostly just read new posts..

It looks like this affected all other images as well.

[gavanderhoorn]

[RFC] Restricting the size of ROS docker images has some more details.

It wasn't communicated too well though imo.

[mathias-luedtke]

The *-base includes too many other dependencies, some undeclared dependencies would be shadowed..

My idea is now to install all needed tools "on-demand".
This way, industrial_ci could be used with any Debian-based image and support use cases like #459

It is not much left anyway: https://github.com/ros-industrial/industrial_ci/blob/master/industrial_ci/src/docker.sh#L235-L248

[ruffsl]

[RFC] Restricting the size of ROS docker images has some more details

pinging @mikaelarguedas , as may be of interest

[mikaelarguedas]

Thanks for the ping,

Would a set of images similar to what is described at osrf/docker_images#408 be of interest?

[mathias-luedtke]

@mikaelarguedas: Yes, that could be a reasonable default choice, at least for the more recent distros :)

[mikaelarguedas]

Good to know.

at least for the more recent distros :)

My initial feeling was to provide these images only for currently active ROS Distro/ OS Distro combinations but a case could be made for a wider set of tags.

If you have feedback or a wishlist of what tags / packages / configuration options you'd like to see in these images, please comment directly on the ticket

[mathias-luedtke]

My initial feeling was to provide these images only for currently active ROS Distro/ OS Distro

Yes, that's fine :)

[gavanderhoorn]

So, is this also related to this issue? Or is it something else?

[mathias-luedtke]

@gavanderhoorn:

It is a regression of #516
And perhaps a problem with catkin-tools, which requires catkin for building non-catkin packages.

[mathias-luedtke]

It is a regression of #516

It would have failed anyway without ROS_REPO=ros
#518 should fix it

[gavanderhoorn]

It would have failed anyway without ROS_REPO=ros

I'm not sure I understand what you mean by this: the repository which had a failed build does have ROS_REPO=ros in the .travis.yml?

[mathias-luedtke]

@gavanderhoorn:
Your repository has ROS_REPO=ros configured, which selects the official Docker image.
If you would have used the default (ROS_REPO=testing), then it would have built the custom Docker image and it would have failed even without the latest changes.

#525 works properly for both cases :)