Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass robot_description content directly to ros2_control.launch.py #78

Open
marip8 opened this issue Feb 20, 2024 · 1 comment
Open

Pass robot_description content directly to ros2_control.launch.py #78

marip8 opened this issue Feb 20, 2024 · 1 comment

Comments

@marip8
Copy link
Member

marip8 commented Feb 20, 2024

Rather than having the ros2_control.launch.py file re-run xacro on an input file, we should just pass the content of robot_description directly as an argument. This should help make the launch process simpler since ROS2 control arguments typically need to be provided to xacro (e.g., use_fake_hardware). Rather than doing this in multiple places, we can invoke xacro once with the desired arguments in the top-level launch file and pass around the contents of robot_description to the other launch files that need it

{'name': 'robot_description_file', 'description': 'Path to the URDF/xacro file', 'default': ''},

@marip8
Copy link
Member Author

marip8 commented Feb 20, 2024

@DavidSpielman can you make a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant