Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log level support to spawner node #972

Merged
merged 3 commits into from
Mar 19, 2023

Conversation

bijoua29
Copy link
Contributor

Want to be able to control the output from the spawner node. This PR adds a log-level argument that is set on the spawner node.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #972 (1bc0344) into master (925f5f3) will decrease coverage by 1.85%.
The diff coverage is 35.84%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
- Coverage   34.61%   32.77%   -1.85%     
==========================================
  Files          52       91      +39     
  Lines        2981     9511    +6530     
  Branches     1855     6408    +4553     
==========================================
+ Hits         1032     3117    +2085     
- Misses        310      676     +366     
- Partials     1639     5718    +4079     
Flag Coverage Δ
unittests 32.77% <35.84%> (-1.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.41% <ø> (-1.30%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 50.00% <ø> (-3.63%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.14% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 69 more

... and 18 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very clean!

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Moreover, great solution for redirecting output of the load_parameter_file function.

@bmagyar bmagyar merged commit 8252a85 into ros-controls:master Mar 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants