Add CM switch_controller service timeout as parameter to spawner.py (backport #1790)
#1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…#1790) Co-authored-by: Felix Exner (fexner) <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> (cherry picked from commit 23bd1c3) # Conflicts: # controller_manager/doc/userdoc.rst # doc/release_notes.rst
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #1879 +/- ##
==========================================
+ Coverage 62.58% 63.18% +0.60%
==========================================
Files 108 109 +1
Lines 12026 12290 +264
Branches 8133 8314 +181
==========================================
+ Hits 7526 7766 +240
+ Misses 880 820 -60
- Partials 3620 3704 +84
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Failing tests due to missing release of ros2_control or #1367
saikishor
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for ros-controls/gz_ros2_control#421 and ros-controls/gazebo_ros2_control#380
If the simulation is started in paused mode, one can now configure also the timeout for the switch_controller service to be completed (the simulation has to be unpaused to perform the controller switches).
Also fixes docs after changes to the spawners in #1562
This is an automatic backport of pull request #1790 done by Mergify.