-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ros2_control_node] Handle simulation environment clocks (backport #1810) #1862
Conversation
(cherry picked from commit d714e8b) # Conflicts: # controller_manager/src/ros2_control_node.cpp # doc/release_notes.rst
Cherry-pick of d714e8b has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1862 +/- ##
==========================================
- Coverage 62.48% 62.47% -0.01%
==========================================
Files 108 108
Lines 12166 12169 +3
Branches 8254 8257 +3
==========================================
+ Hits 7602 7603 +1
- Misses 883 884 +1
- Partials 3681 3682 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As there are many ongoing issues that people are trying to use the ros2_control_node for the simulation environments and as it is not working, I wanted to see if this solution is something that we are interesting to go with or we simple reject the possibility
Related to : #859
This is an automatic backport of pull request #1810 done by Mergify.