Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for params_file parameter in spawner/unspawner tests (backport #1754) #1838

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 3, 2024

Overview


This is an automatic backport of pull request #1754 done by [Mergify](https://mergify.com).

Copy link
Contributor Author

mergify bot commented Nov 3, 2024

Cherry-pick of 84e85f9 has failed:

On branch mergify/bp/humble/pr-1754
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 84e85f9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/test/test_spawner_unspawner.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Nov 3, 2024
Copy link
Contributor Author

mergify bot commented Nov 3, 2024

This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich @saikishor?

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 50.84746% with 29 lines in your changes missing coverage. Please review.

Project coverage is 62.54%. Comparing base (d62377e) to head (2c9c690).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
controller_manager/test/test_spawner_unspawner.cpp 50.84% 0 Missing and 29 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1838      +/-   ##
==========================================
- Coverage   62.57%   62.54%   -0.04%     
==========================================
  Files         108      108              
  Lines       12041    12097      +56     
  Branches     8145     8194      +49     
==========================================
+ Hits         7535     7566      +31     
+ Misses        882      877       -5     
- Partials     3624     3654      +30     
Flag Coverage Δ
unittests 62.54% <50.84%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../controller_manager/controller_manager_services.py 72.41% <ø> (ø)
controller_manager/test/test_spawner_unspawner.cpp 57.39% <50.84%> (-1.50%) ⬇️

... and 1 file with indirect coverage changes

@saikishor saikishor merged commit bba0f0f into humble Nov 3, 2024
9 of 11 checks passed
@saikishor saikishor deleted the mergify/bp/humble/pr-1754 branch November 3, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants