Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usethis::use_github #27

Open
maelle opened this issue Feb 12, 2018 · 10 comments
Open

usethis::use_github #27

maelle opened this issue Feb 12, 2018 · 10 comments

Comments

@maelle
Copy link
Contributor

maelle commented Feb 12, 2018

usethis::use_github could replace step 3 of the review workflow

@maelle
Copy link
Contributor Author

maelle commented Mar 29, 2018

I take this back because it won't work for Windows users at the moment (ask me how I know this 😀 )

@maelle
Copy link
Contributor Author

maelle commented Jun 25, 2018

Now git2r dev version should work on Windows. I guess it's important for the article about pushing the review to GitHub (which I 💙 because screenshots make it seem less daunting for beginners I think!)

@maelle
Copy link
Contributor Author

maelle commented Nov 13, 2018

Note that no, one cannot push using git2r on Windows, so I take this back.

@annakrystalli
Copy link
Collaborator

I believe the latest version of git2r has solved these issues on all systems. I've added the requirement for the latest version. So will close for now.

@maelle
Copy link
Contributor Author

maelle commented Nov 13, 2018

No it hasn't! I still can't push

@annakrystalli annakrystalli reopened this Nov 13, 2018
@annakrystalli
Copy link
Collaborator

Oh! Yes I got confused! Was thinking of the clone problems I was having! OK, I think I have that problem at the moment too. Lemme do a little test

@annakrystalli
Copy link
Collaborator

Yup, failing. Getting this message:

✔ Creating GitHub repository
✔ Adding GitHub remote
✔ Pushing to GitHub and setting remote tracking branch
Error in git2r::push(r, "origin", "refs/heads/master", credentials = credentials) : 
  Error in 'git2r_push': error authenticating: 

However:

use_github(protocol = "https")
✔ Setting active project to '/Users/Anna/Desktop/test_use_github'
● Check title and description
  Name:        test_use_github
  Description: 
Are title and description ok?
1: Yeah
2: Nope
3: No way

Selection: 1
✔ Creating GitHub repository
✔ Adding GitHub remote
✔ Pushing to GitHub and setting remote tracking branch
✔ Opening URL https://github.com/annakrystalli/test_use_github

WORKS! (it uses the PAT I believe)

Wanna try it on Windows?

@annakrystalli
Copy link
Collaborator

I do have an ssh key set up though 🤔

@annakrystalli
Copy link
Collaborator

Oh! I think it might be the 2FA! I think you can't use ssh if you're using 2FA?!

@maelle
Copy link
Contributor Author

maelle commented Nov 14, 2018

I promise nothing works on Windows, I tested many, many things. 😉 Now for pushing with R, I am just waiting for https://github.com/jeroen/gert to be mature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants