Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genbankr removed - may need to fix URL detection? #26

Open
sckott opened this issue Jan 24, 2020 · 14 comments
Open

genbankr removed - may need to fix URL detection? #26

sckott opened this issue Jan 24, 2020 · 14 comments

Comments

@sckott
Copy link
Contributor

sckott commented Jan 24, 2020

after the recent change in the not_transferred.txt file 2d11fdd#diff-ab03bde500c2e24f32f95e7997328b83

the next build of the registry ropensci/roregistry@eab0860 removed genbankr but it's still in https://github.com/ropensci/roregistry/blob/gh-pages/registry_urls.json

the git remote for genbankr is https://git.bioconductor.org/packages/genbankr instead of the typical pattern like https://github.com/CornellLabofOrnithology/auk.git

i'm guessing somewhere in makeregistry R code or in codemeta we don't allow for that url pattern

cc @maelle

@maelle
Copy link
Collaborator

maelle commented Feb 6, 2020

I'm sorry for getting back to this issue so late.

@sckott can you confirm the repo has been cloned to the server?

@sckott
Copy link
Contributor Author

sckott commented Feb 6, 2020

yes, genbankr is cloned on the server

@maelle
Copy link
Collaborator

maelle commented Feb 6, 2020

Right i found a problem in codemetar.

Related question, can one guess a dev repo from a Bioconductor git URL? I.e. if the git URL is https://git.bioconductor.org/packages/genbankr what is the dev repo? I think one cannot guess it? (in which case I'd let that link be NULL)

@maelle
Copy link
Collaborator

maelle commented Feb 6, 2020

@llrs since we've just discussed another Bioconductor thing, I'm asking you: "Related question, can one guess a dev repo from a Bioconductor git URL? I.e. if the git URL is https://git.bioconductor.org/packages/genbankr what is the dev repo? I think one cannot guess it?" Thanks in advance 🙏

@sckott
Copy link
Contributor Author

sckott commented Feb 6, 2020

can one guess a dev repo from a Bioconductor git URL?

dont know

@llrs
Copy link

llrs commented Feb 6, 2020

No problem @maelle. The devel is the master branch. The releases are named branches of the repo RELEASE_3_X. So the devel of genbankr is on master branch on git.bioconductor.org/packages/genbankr and the version for Bioconductor release is on RELEASE_3_10 which is the one shown on bioconductor.org/packages/release/genbankr

@maelle
Copy link
Collaborator

maelle commented Feb 6, 2020

Thank you! And that git repo has no viewable interface like GitHub repos do?

@llrs
Copy link

llrs commented Feb 6, 2020

Not yet, they said they would set up something but at the moment there isn't anything browsable.

@maelle
Copy link
Collaborator

maelle commented Feb 6, 2020

Good to know! Thanks!

@maelle
Copy link
Collaborator

maelle commented Feb 6, 2020

@cboettig does a git URL like above qualify as codeRepository?

@cboettig
Copy link

cboettig commented Feb 6, 2020

Good question -- I think it would, but probably worth us opening an issue on https://github.com/codemeta/codemeta to discuss?

@maelle
Copy link
Collaborator

maelle commented Feb 6, 2020

codemeta/codemeta#234

@maelle
Copy link
Collaborator

maelle commented Mar 2, 2020

I haven't got any answer in the codemeta issue yet @cboettig.

@maelle
Copy link
Collaborator

maelle commented Sep 17, 2020

👋 @cboettig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants