Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does definitions.php need to include the three other files? #1

Open
justincy opened this issue Aug 23, 2012 · 2 comments
Open

Does definitions.php need to include the three other files? #1

justincy opened this issue Aug 23, 2012 · 2 comments
Labels

Comments

@justincy
Copy link
Member

definitions.php includes three other files that are the actual definitions. Are they used elsewhere? Is there any reason the code in those three files can't be copied over to definitions.php?

@DavidTanner
Copy link
Member

At the time it was easier because I had another one, but I pulled it out.
Sometimes I get refactor/seperate happy. My idea was to keep it clean and
easy to read. And it is just a crude first attempt
On Aug 22, 2012 8:15 PM, "Justin" [email protected] wrote:

definitions.phphttps://github.com/rootsdev/rootsdev.org/blob/master/includes/definitions.phpincludes three other files that are the actual definitions. Are they used
elsewhere? Is there any reason the code in those three files can't be
copied over to definitions.php?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1.

@bean5
Copy link
Member

bean5 commented Aug 23, 2012

In a way, it is self-documenting: the definitions page displays the def for
roots, develop and rootsdev...

If you use smarty, those would probably be included only once...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants