Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP User Deprecated: Nette\Http\Session::getIterator() #13

Open
martenb opened this issue Jan 20, 2023 · 4 comments
Open

PHP User Deprecated: Nette\Http\Session::getIterator() #13

martenb opened this issue Jan 20, 2023 · 4 comments

Comments

@martenb
Copy link
Contributor

martenb commented Jan 20, 2023

See https://github.com/nette/http/releases/tag/v3.2.1

@martenb
Copy link
Contributor Author

martenb commented Jan 20, 2023

@martenb
Copy link
Contributor Author

martenb commented Jan 20, 2023

Inspiration here contributte/sentry@964cbc2

@rootpd
Copy link
Owner

rootpd commented Jan 21, 2023

Hi @martenb , I am aware of this. I already handled this in 2.0.0 (specifically ad301dc), but in a different session.

The original approach tracked everything, that Nette session contained, including some internals. I believe that deprecation of Session iterator was implemented exactly because we shouldn't touch/read those internals and only track/log the sessions sections that application is aware of.

Because of that, I'd stick with the implementation introduced in 2.0.0 using explicitly configured session sections.

It wouldn't make sense to copy contributte package anyway, there's no need to have two libraries which work the same way :).

@martenb
Copy link
Contributor Author

martenb commented Jan 22, 2023

Makes sense, didn't noticed v2. Thx for info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants