Skip to content

Commit

Permalink
Merge pull request #454 from kethinov/0.21.4
Browse files Browse the repository at this point in the history
0.21.4
  • Loading branch information
kethinov authored Mar 18, 2023
2 parents 242047f + 7a0ea24 commit bab6955
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 24 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

- Put your changes here...

## 0.21.4

- Fixed bug resulting in a non-fatal error when generating apps.

## 0.21.3

- Enabled source-maps on webpack by default.
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ If you are a maintainer of generator-roosevelt, please follow the following rele

### Important note: Do a new release of mkroosevelt with every release of generator-roosevelt

Even though `generator-roosevelt` is listed as `*` in mkroosevelt's package.json, the package-lock.json still needs to be regenerated every time `generator-roosevelt` is pushed to npm. As such, whenever doing a publish of `generator-roosevelt`, you should also bump the version number of `mkroosevelt` to match, regenerate the package-lock.json, and publish `mkroosevelt` to npm as well.
The package-lock.json file in `mkroosevelt` needs to be regenerated every time `generator-roosevelt` is pushed to npm. As such, whenever doing a publish of `generator-roosevelt`, you should also bump the version number of `mkroosevelt` to match, regenerate the package-lock.json, and publish `mkroosevelt` to npm as well.
6 changes: 4 additions & 2 deletions generators/app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,8 @@ module.exports = class extends Generator {

end () {
;(async () => {
const terminalLink = await import('terminal-link')
const terminalLinkPkg = await import('terminal-link')
const terminalLink = terminalLinkPkg.default

if (!this.options['skip-closing-message']) {
this.log(`\nYour app ${this.appName} has been generated.\n`)
Expand All @@ -806,8 +807,9 @@ module.exports = class extends Generator {
this.log('- To run in development mode: npm run d')
this.log('- To run in production mode: npm run p')
const url = 'https://localhost:' + this.httpsPort
const help = 'https://github.com/rooseveltframework/roosevelt#configure-your-app-with-parameters'
this.log('- Once running, visit: ' + terminalLink(url, url) + '\n')
this.log('To make further changes to the config, edit package.json. See https://github.com/rooseveltframework/roosevelt#configure-your-app-with-parameters for information on the configuration options.')
this.log('To make further changes to the config, edit package.json. See ' + terminalLink(help, help) + ' for information on the configuration options.')
}
})()
}
Expand Down
40 changes: 20 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"url": "https://github.com/rooseveltframework/generator-roosevelt/graphs/contributors"
}
],
"version": "0.21.3",
"version": "0.21.4",
"files": [
"generators"
],
Expand Down

0 comments on commit bab6955

Please sign in to comment.