Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending cephfs stale cleanup #272

Open
Madhu-1 opened this issue Apr 2, 2024 · 4 comments · Fixed by #302
Open

Pending cephfs stale cleanup #272

Madhu-1 opened this issue Apr 2, 2024 · 4 comments · Fixed by #302
Assignees

Comments

@Madhu-1
Copy link
Member

Madhu-1 commented Apr 2, 2024

This tracks the pending work for cephfs stale volumes

  • volumes created for NFS csi drivers
  • ROX PVC
  • stale volumesnapshot cleanup
  • Pending clones (?)

@yati1998 above cases are already covered or yet to be covered? Do we have a tracker for it? (i tried to find one but not able to)

@yati1998
Copy link
Contributor

yati1998 commented Apr 2, 2024

  1. In the case of pending clones, we won't have subvolumes created at the backend (as per my testing) and hence, I don't think we need to bother about the pending clones. Please correct me if I am wrong.
  2. How do we consider a volume snapshot as stale? According to my plan, we are restoring the snapshots so that they can be used to restore the volumes if required.
  3. NFS csi drivers are covered with the same logic as a normal csi driver, just an additional step for cleanup of its extra configuration stored needs to be done, we can use this issue itself to track that.
  4. Not sure what has to be done for ROX PVC separately!!

@Madhu-1
Copy link
Member Author

Madhu-1 commented Apr 3, 2024

  1. In the case of pending clones, we won't have subvolumes created at the backend (as per my testing) and hence, I don't think we need to bother about the pending clones. Please correct me if I am wrong.

Yes it will be created when we create PVC from PVC/Snapshot, please check on this one,

  1. How do we consider a volume snapshot as stale? According to my plan, we are restoring the snapshots so that they can be used to restore the volumes if required.

Anyone can delete the kubernetes yamls and the backend snapshot might not get deleted.

  1. NFS csi drivers are covered with the same logic as a normal csi driver, just an additional step for cleanup of its extra configuration stored needs to be done, we can use this issue itself to track that.
    👍🏻
  2. Not sure what has to be done for ROX PVC separately!!

This also need to be considered where Ref counters/backend snapshot etc need to be checked and cleaned up if required.

@yati1998
Copy link
Contributor

Except the ROX pvc, rest all cases are being covered.

@yati1998
Copy link
Contributor

#307
#311
#312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants