Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] TypeScript support #92

Open
stargazing-dino opened this issue May 20, 2019 · 4 comments
Open

[Feature Request] TypeScript support #92

stargazing-dino opened this issue May 20, 2019 · 4 comments

Comments

@stargazing-dino
Copy link

Would love to see a types file defined for this library as it really is good.

@Redmega
Copy link
Collaborator

Redmega commented May 22, 2019

PRs always welcome 😉

I've been using a lot of Typescript lately. If you don't care to make a PR adding typings (or converting to TS, though I'm not sure how @romainberger feels about a full conversion) I might be able to get around to it eventually. I've been insanely busy so I haven't had the chance or motivation to check on this library in a while.

@romainberger
Copy link
Owner

Yeah I haven't used Typescript for now so if there is a possibility to keep it as is and add types separately that'd be cool 👍

@stargazing-dino
Copy link
Author

I've never written one but I think I could figure it out. If anyone else feels the urge to write one and get a PR in quick, please don't let me stop you

@naortor
Copy link

naortor commented Jun 2, 2020

Hi, I created types @ definitely typed.

Now in PR DefinitelyTyped/DefinitelyTyped#45221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants