Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting output_schema is skipped when there are no read types #539

Open
solnic opened this issue Apr 29, 2019 · 1 comment
Open

Setting output_schema is skipped when there are no read types #539

solnic opened this issue Apr 29, 2019 · 1 comment
Assignees
Milestone

Comments

@solnic
Copy link
Member

solnic commented Apr 29, 2019

This makes sense in case of adapters where key coercion is not required, but when it is, we ALWAYS need to use an output_schema because it will handle key coercion even when there are no read types defined.

This already caused issues in rom-elasticsearch and rom-http, both currently override output_schema Relation option as a workaround.

@solnic
Copy link
Member Author

solnic commented Jul 23, 2019

@flash-gordon what's the best way to detect if a hash schema has key types that require coercion? (talking about dry types schemas)

@solnic solnic modified the milestones: 5.1.0, 5.2.0 Jul 26, 2019
@solnic solnic modified the milestones: 5.2.0, 6.0.0 Jun 24, 2020
@solnic solnic self-assigned this Jan 12, 2021
@solnic solnic moved this to Backlog in rom-rb 6.0 May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant