New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schneiderのピンをmain関数で与える #194

Open

H1rono opened this issue May 26, 2024 · 1 comment

Labels

Member

H1rono commented May 26, 2024

omniboat_robokit/src/schneider_model.cpp

Lines 28 to 29 in 2d3b5b3

    
           Schneider::Schneider() : 
        
               input_modules({A4, A5}, A6, {D4, D5}), output_modules({PB_4, PA_11}, {PA_9, PA_10}), service() {

mainで↓と書けるようにしたい

omniboat::Schneider schneider{
    {{A4, A5}, A6, {D4, D5}},       // input_modules
    {{PB_4, PA_11}, {PA_9, PA_10}}, // output_modules
};

流石にどれがどれかわからなくなるのでBuilderの導入を検討 #192
Builderを使う形に変更できたらclose

H1rono added the enhancement label

Member Author

H1rono commented May 30, 2024

とりあえずmain関数から与える形にしてデフォルトコンストラクタを消したい

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment