Support using ccache when building gengetopt and ragel #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Please take a look at the part of task about cross-compilation. We can't just use CC and CXX because they're set to cross-compiler, not native compiler. |
github-actions
bot
added
the
work in progress
Okay, so we need to make sure that CC and CXX are always passed with native compilers instead of the cross compilers for ragel and gengetopt? |
|
Yes, because they are build tools running during build. |
jeshwanthreddy13
changed the title
github-actions
bot
added
ready for review
gavv
reviewed
Jun 20, 2024
gavv
added
needs revision
github-actions
bot
added
ready for review
Fixes #639 - Implemented ccache support when building gengetopt and ragel in file 'build-3rdparty.py'. - Added 'CC' and 'CXX' paramters when executing './configure' so as to inject ccache when '--compiler-launcher=ccache' is used. Additional Notes: - Added two new functions "detect_compiler_presence" "detect_native_cc_cxx_compilers" for detecting if a particular native compiler is present or not by executing it with -v argument. - Added a third optional argument 'env' in function "format_vars" to format using that argument when it is passed.
|
Thanks!! Small follow-up commit: bf5e365 (see commit message for details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639
Additional Notes: