IRIError and SchemaError are not used

[robstewart57]

ping @wismill

Where are IRIError and SchemaError used?

I would've thought that the left value for the following functions:

mkIRI :: Text -> Either String IRI
parseIRI :: Text -> Either String IRIRef
parseRelIRI :: Text -> Either String IRIRef
validateIRI :: Text -> Either String Text
resolveIRI :: Text -> Text -> Either String Text

Would be IRIError or SchemaError rather than String?

[wismill]

You are right, they are not used yet. The compiler did not catch this because they are in the export list.

Maybe we could keep things simple and use the parser combinator <?> to make the error message and remove IRIError and SchemaError?

[robstewart57]

Maybe we could keep things simple and use the parser combinator <?> to make the error message and remove IRIError and SchemaError?

Sounds sensible to keep things simple.

How about using the library's existing ParseFailure:

rdf4h/src/Data/RDF/Types.hs

Line 483 in 8b5b06f

newtype ParseFailure = ParseFailure String

E.g. it's used

rdf4h/src/Data/RDF/Types.hs

Line 403 in 8b5b06f

class RdfParser p where

in

class RdfParser p where
  parseString :: (Rdf a) => p -> Text -> Either ParseFailure (RDF a)
  parseFile :: (Rdf a) => p -> String -> IO (Either ParseFailure (RDF a))
  parseURL :: (Rdf a) => p -> String -> IO (Either ParseFailure (RDF a))

I.e.

mkIRI :: Text -> Either ParseFailure IRI
parseIRI :: Text -> Either ParseFailure IRIRef
parseRelIRI :: Text -> Either ParseFailure IRIRef
validateIRI :: Text -> Either ParseFailure Text
resolveIRI :: Text -> Text -> Either ParseFailure Text