IE8 failure (lack of Array.prototype.forEach)

[danielmohacsi]

It seems that the add method fails in ie8. The reason is that this function calls a forEach on the dep variable. IE8 does not support the Array.prototype.forEach iterator.

I have a workaround for it, using node's forEach implementation to provide an Array.prototype.forEach method, but it's not nice. It would be better if orchestrator used node's forEach implementation by default.

[yocontra]

Use es5-shim

[rgabo]

@contra thanks for the follow up. We're third-party javascript library, integrated into the messiest websites that you can imagine. Changing/polluting the global scope, especially prototypes is super dangerous because we can break past and future functionality of our customers. So we try to be super defensive and conservative about it.

As such, es5-shim is not an option, but providing the missing forEach implementation temporarily while orchestrator relies on it does fix the issue. We restore whatever Array.prototype.forEach was before we set it.

If we were to send you a PR that avoids the native Array.prototype.forEach, would you consider merging it? We'll maintain the fork otherwise.

Thanks!

[yocontra]

@rgabo Generally you will find it hard to get a project maintainer to consider that. We don't usually write stuff for ES3 anymore, most people have already moved on to ES6. Maybe rob would consider using _.forEach would be reasonable because that provides more than just backwards compat, it's actually faster.