Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm v3 ability to pass --history-max argument on the release level #868

Open
zen4ever opened this issue Sep 20, 2019 · 3 comments
Open

Comments

@zen4ever
Copy link

Helm v3 has an argument

--history-max int          limit the maximum number of revisions saved per release. Use 0 for no limit.

but it doesn't seem like there is a way to pass it.
I've tried to pass it via

helmDefaults:
  args:
    - --history-max
    - 5

It works for upgrade command, but "helm list" command fails with

Listing releases matching ^ingx$
exec: helm list --filter ^ingx$ --history-max 5
exec: helm list --filter ^ingx$ --history-max 5:
getting deployed release version failed:helm exited with status 1:
  Error: unknown flag: --history-max
worker 2/2 finished

Ideally, there will be a variable "historyMax" on the release level.

@nauxliu
Copy link
Contributor

nauxliu commented Dec 10, 2019

I agree. historyMax on release level would be awesome. I'm willing to implement this.

mumoshu pushed a commit that referenced this issue Dec 16, 2019
@abrarcv170
Copy link

@nauxliu @mumoshu after this change the helm environment variable HELM_MAX_HISTORY is not working

@yxxhero
Copy link
Contributor

yxxhero commented Aug 23, 2022

see: #2148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants