Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SIGTERM for dependent helm processes #2160

Open
jonnylangefeld opened this issue Nov 20, 2022 · 2 comments
Open

Handle SIGTERM for dependent helm processes #2160

jonnylangefeld opened this issue Nov 20, 2022 · 2 comments

Comments

@jonnylangefeld
Copy link

helm handles SIGTERM gracefully.
helmfile captures SIGTERM, but does nothing to pass the SIGTERM on to the helm processes to roll back those charts.
This is often painful in CI when many charts get stuck due to a SIGTERM and an immediate shutdown of the agent, once the helmfile process exited. At this time the helm processes might still be working and get killed by the agent, which leaves the chart in the "pending-install" state, from which one can only manually recover.

helmfile should pass the SIGTERM to the child processes and only exit once all child processes exited.

@yxxhero
Copy link
Contributor

yxxhero commented Nov 20, 2022

@jonnylangefeld please use v0.148.1

@yxxhero
Copy link
Contributor

yxxhero commented Nov 20, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants