Add support for --no-hooks option on diff

[mcavoyk]

The Helm diff plugin has a --no-hooks option which suppresses diff of Helm hooks when used. This option would be nice at either the release level or cli helmfile diff level.

Unintended behavior of this not being supported is that helm charts which use Helm hooks end up with misleading diffs and also upgrade being run on apply when no resources have changed.

[mumoshu]

@mcavoyk Thanks for the proposal - that makes sense!

Out of curiosity, what would be the "best" behavior regarding this?

Is diff on hooks still useful when you do have an update on your chart? In that case, we can perhaps collaborate with helm-diff to add an alternative mode that prints diff on hooks only when a release has diff for non-hook resources.

[mcavoyk]

The best behavior would be that helm diff understand the lifecycle of the specified hooks and only diff when the hook would actually be applied.

I think the next best would be to control --no-hook behavior within helmfile so that the diff of hook resources are ignored.

[bobmacks]

Any updates on this request? We also require the ability to ignore post-install hooks from helmfile diffs.

[mumoshu]

@bobmacks Hey! Thanks for your attention. I'd say it's generally not a good idea to just ask for updates in a volunteer-driven open-source project, as no one is forced to spend time on it.
This seems like a valid feature though! I'd definitely try to review any pull requests related to this.
Would you mind contributing it?

[arpanadhikari]

@mumoshu , I've put my hand up for this. Will give it a shot. Looks straight forward enough. :)

[yxxhero]

@arpanadhikari https://github.com/helmfile/helmfile. Welcome to create PRs in this repo. see: #2148

[arpanadhikari]

Amazing. Finally moved to its well deserved separate org. Thanks @yxxhero .