Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Specify Application/File Browser Ports for Internal Apps #250

Merged
merged 7 commits into from
Oct 3, 2024
Merged

PR: Specify Application/File Browser Ports for Internal Apps #250

merged 7 commits into from
Oct 3, 2024

Conversation

tunahanertekin
Copy link
Member

🌿 PR: Specify Application/File Browser Ports for Internal Apps

Description

  • New labels are defined for RobotIDE, RobotVDI and Notebook.
    • robolaunch.io/ide-port - for RobotIDE
    • robolaunch.io/vdi-port - for RobotVDI
    • robolaunch.io/notebook-port - for Notebook
    • robolaunch.io/ide-fb-port - for RobotIDE
    • robolaunch.io/vdi-fb-port - for RobotVDI
    • robolaunch.io/notebook-fb-port - for Notebook

Closes #249

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How can it be tested?

Can be tested by adding labels to the corresponding custom resources.

@tunahanertekin tunahanertekin added the enhancement New feature or request label Oct 3, 2024
@tunahanertekin tunahanertekin self-assigned this Oct 3, 2024
@tunahanertekin tunahanertekin linked an issue Oct 3, 2024 that may be closed by this pull request
Specify Application Ports #249
Closed
@tunahanertekin tunahanertekin merged commit 95c90eb into main Oct 3, 2024
1 check passed
@tunahanertekin tunahanertekin deleted the 249-port-specification-v2 branch October 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tunahanertekin tunahanertekin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify Application Ports
1 participant
@tunahanertekin