-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make target Ghidra repo configurable #19
base: master
Are you sure you want to change the base?
Conversation
Includes action updates & cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the interest!
Most of the changes look good, but I'll need to merge them piece by piece to make sure I understand what the changes entail.
This repository's CI is a bit sensitive since it contains my Apple Dev Certificate and API keys to sign/notarize the releases, so this may take a bit.
1824434
to
dbff48e
Compare
4d9fe32
to
ba5f1b4
Compare
72b5cf0
to
82881ec
Compare
Sorry for the very long delay. I pulled some of your changes manually, split them into dedicated commits, and adapted them a bit. On the externally visible side of things:
I also included a few of your other changes like putting the JAVA_VERSION and GRADLE_VERSION in an env block so it can be easily changed, renaming ghidra-ci-roblabla to ghidra-ci, and some of the simplifications. A lot of the remaining changes are either cosmetic in nature (changing the step names, yaml formatting and whatnot), or not really necessary (upgrading the actions) so I left them out for now. I'll try to go over them soon-ish. I also didn't pull the change to the artifact name, as having a consistent artifact name is convenient when trying to Thanks for the contribution. |
bf795ef
to
4ce5322
Compare
4ce5322
to
d7b5ade
Compare
Primarily, this is intended to make it easier for forks to update the target Ghidra repository. An example of these changes: https://github.com/encounter/ghidra-ci
actions/create-release
)ghidra_11.1_DEV_20240120.zip
instead ofrelease.zip
)Thanks for setting this up! It's saved an immense amount of time.