Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make target Ghidra repo configurable #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

encounter
Copy link

Primarily, this is intended to make it easier for forks to update the target Ghidra repository. An example of these changes: https://github.com/encounter/ghidra-ci

  • Centralize repo and dependency version configuration
  • Update all actions (+ replace unmaintained actions/create-release)
  • Simplify artifact & release handling
  • Better release artifact names (e.g. ghidra_11.1_DEV_20240120.zip instead of release.zip)
  • Allow prevRev to be empty ("fallback" changelog is generated instead)
  • Various cosmetic changes (names for all steps, etc)

Thanks for setting this up! It's saved an immense amount of time.

Includes action updates & cleanup
Copy link
Owner

@roblabla roblabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the interest!

Most of the changes look good, but I'll need to merge them piece by piece to make sure I understand what the changes entail.

This repository's CI is a bit sensitive since it contains my Apple Dev Certificate and API keys to sign/notarize the releases, so this may take a bit.

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/check_new_commits.yml Show resolved Hide resolved
@roblabla
Copy link
Owner

roblabla commented Aug 31, 2024

Sorry for the very long delay.

I pulled some of your changes manually, split them into dedicated commits, and adapted them a bit. On the externally visible side of things:

  • The changelog now uses the fallback when prevRev isn't available
  • The PAT_TOKEN is now unnecessary for the workflow dispatch call.
  • It's possible to configure the ghidra repo by setting a variable (GHIDRA_REPO) in the repo settings (settings -> secrets and variables -> actions -> variables -> new repository variable). I added some documentations in the README on how to achieve this.

I also included a few of your other changes like putting the JAVA_VERSION and GRADLE_VERSION in an env block so it can be easily changed, renaming ghidra-ci-roblabla to ghidra-ci, and some of the simplifications.

A lot of the remaining changes are either cosmetic in nature (changing the step names, yaml formatting and whatnot), or not really necessary (upgrading the actions) so I left them out for now. I'll try to go over them soon-ish.

I also didn't pull the change to the artifact name, as having a consistent artifact name is convenient when trying to wget the latest version easily ^^'.

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants