Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support trailing comma after the last argument. #520

Merged
merged 1 commit into from
May 3, 2024
Merged

Support trailing comma after the last argument. #520

merged 1 commit into from
May 3, 2024

Conversation

linuxerwang
Copy link
Contributor

Example:

function mergeObjects(x, y) { /* dummy body */}

mergeObjects(
    { "duck": "quack" },
    { "dog": "bark" }, // Allow trailing comma after the last argument.
);

@linuxerwang
Support trailing comma after the last argument.
f3d2744 
Example:

```js
function mergeObjects(x, y) { /* dummy body */}

mergeObjects(
    { "duck": "quack" },
    { "dog": "bark" }, // Allow trailing comma after the last argument.
);
```
@stevenh stevenh merged commit 2d23528 into robertkrimen:master May 3, 2024
2 checks passed
@tlimoncelli
Copy link

Thank you so much! I've wanted this feature for years!

(Take a peek at https://github.com/StackExchange/dnscontrol/releases/tag/v4.15.0)

@BrewTestBot BrewTestBot mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenh stevenh stevenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linuxerwang @tlimoncelli @stevenh