Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing character encoding conversion using Encode and other small fixes #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PhobosK
Copy link

@PhobosK PhobosK commented Aug 1, 2015

Hi,
Here are the changes I propose:

  • I did change the way the encoding conversion is done. It doesn't use piconv by a system call anymore, since piconv is actually Perl Encode. I removed all system() calls since they are not needed and have problem with file naming (if unquoted, encoding etc). The logic now is that if the char encoding conversion fails, we at least will have a valid non-char-encoding-converted file... All this closes Error: function tmpnam undefined. #2 as well...
  • I did fix the subtitle formats naming mix-up, so this will close README: subtitle types mixed up #3 too...
  • Some spelling and formatting clean-ups
  • A version bump up to 0.5.6

If you like you may accept this pull request

Thanks

PhobosK added 2 commits August 1, 2015 02:14
[REMOVED] Usage of system calls and piconv
[FIXED] Some spelling mistakes
[FIXED] Minor fix for encoding conversion (closes robelix#2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README: subtitle types mixed up Error: function tmpnam undefined.
1 participant