Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #4

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add Dockerfile #4

wants to merge 10 commits into from

Conversation

thgh
Copy link

@thgh thgh commented Jul 14, 2023

Hi,

Resolves #3

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2023

CLA assistant check
All committers have signed the CLA.

@robbie-cahill
Copy link
Owner

I'm fine to add the Dockerfile, but the PR shows 43 files changed? I think it should just have only the Dockerfile as a new file with no changes to the other files.

@cpontvieux-systra
Copy link

First commit from the PR is doing the minimum to get a Dockerfile running though I agree, the PR is full of other modifications.

@thgh
Copy link
Author

thgh commented Nov 28, 2024

Feel free to use as inspiration. Best to inspect commit per commit, more specifically 323b55e and f1bc0f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image
4 participants