New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang-format #28

Open

JensWehner opened this issue Jan 17, 2021 · 1 comment · May be fixed by #51

Labels

Milestone

Contributor

JensWehner commented Jan 17, 2021

Would you be interested in using clang-format to have a standard format of your source code?

I would submit a PR for that if you find

Advantages:

all code has the same format, consistency
When reviewing formatting can be checked automatically
Makes other automated refactoring of the code easier
clear specification of what format is expected

Disadvantages:

clang-format formats slightly differently from version to version, so we would need to agree on one
typically one would reformat the whole codebase in one commit, which would trash the history a little bit, because nearly every line in the code will be touched.

Owner

robashaw commented Jan 24, 2021

I'm tagging this as a v1.1 goal, as I like the idea in principle but it's certainly not a priority change right now.

robashaw added the enhancement label

robashaw added this to the 1.1 milestone

JensWehner mentioned this issue

added clang-format structure #30

Closed

robashaw linked a pull request

that will close this issue

Draft

robashaw linked a pull request

that will close this issue

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment