Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to pass your own requests class into the client #70

Open
kuhanaklobasa opened this issue Jan 17, 2022 · 1 comment
Open

Comments

@kuhanaklobasa
Copy link

kuhanaklobasa commented Jan 17, 2022

Is your feature request related to a problem? Please describe.
Yes, I wanted to customise timeouts but I didn't have a way so I wrote spaghetti code :=)

If your feature is related to implementing a new Roblox API, provide information here.
API URL: none
Documented: none

Describe the solution you'd like
Add an option to pass your own requests class into the client

Describe alternatives you've considered
None

Additional context

session = httpx.Session(timeout=10)
requests = Requests(
    url_generator=None,
    session=session
)
client = Client(requests=requests)
@jmkd3v
Copy link
Collaborator

jmkd3v commented Mar 18, 2022

going to do this for v3 along with aiohttp and pydantic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants