Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move command (tm) shows directory of highlighted torrent in prompt instead of marked torrent(s) #192

Open
Soundtoxin opened this issue Mar 26, 2021 · 10 comments

Comments

@Soundtoxin
Copy link

First let me explain what leads to this issue. I have 4 adjacent torrents I added in a stopped state. I want to move them all from the default directory to a different one, but the same different one. So I start at the top torrent and press space 4 times. As you know, it moves the cursor down after selection. So then if I press tm, I'm actually on a 5th torrent that I did not mark, and it tries to move that one instead of the four I have just marked.
So, in practice I have to do space-space-space-space-k-tm to make sure I'm on one of the marked torrents instead of just space-space-space-space-tm to execute the move from anywhere.
This behavior is undesirable to me. I'm not sure if it was done on purpose or not.

@rndusr
Copy link
Owner

rndusr commented Mar 26, 2021 via email

@Soundtoxin
Copy link
Author

I admit there was some guesswork here. I sad that the move prompt displayed the location of the focused unmarked torrent, but I hit esc instead of changing it. Is it possible it was going to move the marked torrents, but just set the wrong current dir in the prompt? In that case I would think it's still a bug, but a different one.

@Soundtoxin
Copy link
Author

Soundtoxin commented Mar 26, 2021

Okay, I just tested (probably should've just done so before posting again). It is like I started to guess. Although it displays the dir where the focused thing is, when I actually do the move, it is indeed the marked things that it tries to move.

@Soundtoxin Soundtoxin changed the title Move command (tm) acts on highlighted torrent when others are marked Move command (tm) shows directory of highlighted torrent in prompt instead of marked torrent(s) Mar 26, 2021
@rndusr
Copy link
Owner

rndusr commented Mar 26, 2021 via email

@Soundtoxin
Copy link
Author

I want to see the current directory of the (4) stopped torrents that are marked, but instead it shows the one of what my cursor happened to be on. Normally it shows the current directory and then changes it to what you set. Here it's basically showing irrelevant info, and if I accidentally hit enter it would actually move a bunch of stuff to an unrelated spot. I guess it's basically just the same behavior as if nothing were marked, but it is confusing this way.

@rndusr
Copy link
Owner

rndusr commented Mar 26, 2021 via email

@Soundtoxin
Copy link
Author

That is an interesting problem. I think the current directory of at least one of the marked torrents should be shown, maybe the last-marked one.

@rndusr
Copy link
Owner

rndusr commented Mar 26, 2021 via email

@Soundtoxin
Copy link
Author

Soundtoxin commented Mar 26, 2021

Last one chronologically. I think this is better than first because if you suddenly regret which one was last marked (and thus sets the default location) you can mark another one, even unmark and remark one that was already marked so it's now the "last". If you did it with the first, you'd have to unmark everything to do the same thing.

I have a somewhat related question, what's the syntax to add a keybind that's similar to tm but without showing the current location at all?
I tried
bind t+M setcommand 'move '
and
bind t+M 'setcommand move '
but neither work. (I also tried no single quotes anywhere first)
I checked the stig keys help page and the format of the defaults binds it lists already looks different than some binds I have, so I figure it must not be exactly how they go in the rc file. Also they don't use any quoting.

@rndusr
Copy link
Owner

rndusr commented Mar 26, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants