-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Removing "react-native" from repo names and moving packages to @react-native-community #33
Comments
Uhm I'm fairly sure there was already a conversation on this somewhere... I can't find it right now. |
Renaming Github repos is a good idea and shouldn't come with many downsides. Github automatically sets up redirects for the old names, so it should be fairly straightforward. Releasing everything under the
Maybe it's worth talking to the maintainers of a library which has made a change to NPM package names about their experience with it? Babel comes to mind. |
Also, what do you mean by "bring all packages under RNC"? |
@pvins |
Fully supportive, we already renamed a bunch, like CLI or ART. |
@sbeca wants to move https://github.com/react-native-community/react-native-audio-toolkit under how can he do that? |
Yeah, react-native-audio-toolkit was transferred from Futurice's Github account to the react-native-community Github account a few months ago but is still under Futurice's npm account. What is the process for transferring the npm package to the react-native-community npm account? |
@thymikee when you have a minute, could you please outline steps that you guys took in order to make this happen? Once we have solid "miniguide" I could open proposal issues in each repo mentioning those (hopefully this won't be too spammy, but rather ensure all maintainers are aware?). I guess we need to know how to: rename repo to remove 'react-native' and move npm package under rnc org with least resistance to maintainers and end users. |
That's it, GH takes care of everything else for us. If the package is not published as scoped, then it needs a discussion, but we should strive to have it sooner or later. |
If we're going to rename the NPM packages, we should have a plan to make it clear to existing users what they need to do to migrate. Possible options are:
I recently went through this as a library user with RNC Blur View. I only noticed that the package name as changed after going to the GitHub page. If I hadn't have done that I would be "stuck" on the old version. |
So, for react-native-audio-toolkit I should do the following:
I am not part of the react-native-community NPM organisation yet so who can help me with step 1? My NPM username is |
I think @kelset can give you a hand with that 😃 |
👋 @sbeca. In the meantime, there are a few other house cleaning things that I'd need your help with (for example, in the maintainers https://github.com/react-native-community/.github/blob/master/MAINTAINERS.md you are not listed 😅). If you are on twitter, could you send me a dm there so that I can guide you through a few of these things? |
I'll send you a DM now @kelset |
Proposal
I want to propose 2 changes, that (in my opinion) could further improve "consistency" feeling around react-native-community org
react-native
from package names underreact-native-community
since organisation name already implies it.@react-native-community/
namespace in package registryDiscussion
@react-native-community/
namespace and possible solutions to solve them?Present status
There are several examples that show case this proposal within the community already: cli, apple-sign-in, art etc..
I also mentioned this in react-native-svg repository via software-mansion/react-native-svg#1021
The text was updated successfully, but these errors were encountered: