Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

A small fun programming task to do -> aggreate what the signers said on their pull request. #3828

Open
shenlebantongying opened this issue Mar 27, 2021 · 8 comments

Comments

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Mar 27, 2021

After merging a lot of pull requests, I know there are a lot of people leaving a memo on why they sign. Maybe we can extract them via GitHub's CLI tool. Those messages go into void after signing, how about we collect them?

Examples:
#3824
#3823

It is not urgent or critical, but it may be interesting to see they what they said :)

@shenlebantongying shenlebantongying changed the title A small fun programming task to do -> aggreate what signers say on their pull request. A small fun programming task to do -> aggreate what the signers said on their pull request. Mar 27, 2021
@C-xC-c
Copy link
Contributor

C-xC-c commented Mar 28, 2021

This sounded like a fun exercise, so I made a program to scrape pull requests and collect their titles and bodies. You can view them in JSON format here: https://tyrer.dev/rms-support-letter-comments.json

It should update once an hour with new PRs, feel free to use it any way you like.

Code is here: https://github.com/C-xC-c/PrScraper/tree/main

@akozlovskiy119
Copy link
Contributor

I'm not the owner or collaborator but I think it's too late now. The letter author and the repository owner should have explicitly mentioned from the beginning (in README, PR template) that the signers can leave their reasons for signing or wishes to RMS/FSF. Now the messages are mostly empty/+1 signed/signed, etc. Some even are not related to the letter. Don't forget other resources too (codeberg, mailing list).

Also, I think a better way would be to make a new optional commentary: or wish: entry in the .yaml file.

@shenlebantongying
Copy link
Collaborator Author

shenlebantongying commented Mar 28, 2021

@akozlovskiy119 It's not late actually. A LOT of people do this naturally already :)

@C-xC-c Can you add a filter for none and 1 word PRs?

@akozlovskiy119
Copy link
Contributor

akozlovskiy119 commented Mar 28, 2021

My point is that it's not really fair to those who have already signed and didn't know they could/should leave a message. It's like they were not informed and missed the opportunity. But many do leave them, of course.

Some stats would be good though. Also when filtering the messages consider that not all PRs made are signatures. That there are reverted PRs. That there are PRs without any standard words like sign/add/create/pull/support in header but with a non-empty meaningful message like #3628. That there can be PRs without message but related commit with it or vice-versa. Or that commit message could differ from PR message but both contain an important info.

@shenlebantongying
Copy link
Collaborator Author

Even we dont suggest or force them to leave a message, they still write down something even they may know its going into void. Those words are come from their own thought completely. Its beautiful and very genuine. I don't think we have to distribute it by adding a field, since there are plenty of notes already.

Just my 2 cents.

@C-xC-c
Copy link
Contributor

C-xC-c commented Mar 28, 2021

@C-xC-c Can you add a filter for none and 1 word PRs?

Empty comments should be removed!
There's still a few that are just newlines and such but I'm getting rate limited, should have those fixed soon.

@6r1d
Copy link
Member

6r1d commented Mar 28, 2021

My point is that it's not really fair to those who have already signed and didn't know they could/should leave a message. It's like they were not informed and missed the opportunity. But many do leave them, of course.

We can add automated comments in pull requests, too!

@hinell
Copy link
Contributor

hinell commented Mar 30, 2021

@C-xC-c CSharp? You must be kidding me. This could have been achieved by a simple bash script. Great work anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants