-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
A small fun programming task to do -> aggreate what the signers said on their pull request. #3828
Comments
This sounded like a fun exercise, so I made a program to scrape pull requests and collect their titles and bodies. You can view them in JSON format here: https://tyrer.dev/rms-support-letter-comments.json It should update once an hour with new PRs, feel free to use it any way you like. Code is here: https://github.com/C-xC-c/PrScraper/tree/main |
I'm not the owner or collaborator but I think it's too late now. The letter author and the repository owner should have explicitly mentioned from the beginning (in README, PR template) that the signers can leave their reasons for signing or wishes to RMS/FSF. Now the messages are mostly empty/+1 signed/signed, etc. Some even are not related to the letter. Don't forget other resources too (codeberg, mailing list). Also, I think a better way would be to make a new optional |
@akozlovskiy119 It's not late actually. A LOT of people do this naturally already @C-xC-c Can you add a filter for none and 1 word PRs? |
My point is that it's not really fair to those who have already signed and didn't know they could/should leave a message. It's like they were not informed and missed the opportunity. But many do leave them, of course. Some stats would be good though. Also when filtering the messages consider that not all PRs made are signatures. That there are reverted PRs. That there are PRs without any standard words like sign/add/create/pull/support in header but with a non-empty meaningful message like #3628. That there can be PRs without message but related commit with it or vice-versa. Or that commit message could differ from PR message but both contain an important info. |
Even we dont suggest or force them to leave a message, they still write down something even they may know its going into void. Those words are come from their own thought completely. Its beautiful and very genuine. I don't think we have to distribute it by adding a field, since there are plenty of notes already. Just my 2 cents. |
Empty comments should be removed! |
We can add automated comments in pull requests, too! |
@C-xC-c CSharp? You must be kidding me. This could have been achieved by a simple bash script. Great work anyway. |
After merging a lot of pull requests, I know there are a lot of people leaving a memo on why they sign. Maybe we can extract them via GitHub's CLI tool. Those messages go into void after signing, how about we collect them?
Examples:
#3824
#3823
It is not urgent or critical, but it may be interesting to see they what they said
:)
The text was updated successfully, but these errors were encountered: