Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove torch dependency. #10

Open
rmlarose opened this issue May 24, 2019 · 2 comments
Open

Remove torch dependency. #10

rmlarose opened this issue May 24, 2019 · 2 comments

Comments

@rmlarose
Copy link
Owner

As far as I know (@naezzell correct me if I'm wrong), we're only using torch to do PCA. Torch is a huge download -- only using PCA from it is a waste. We should avoid this by using a native implementation of PCA, or another way around the torch dependency.

I'm not adding torch to requirements.txt with the expectation that it will be removed.

@naezzell
Copy link
Collaborator

naezzell commented May 24, 2019

It's removed from PCA (reduce_features), but torchvision is still used to get certain data sets. Yousif probably only did it this was since original PCA did use PyTorch already.

@rmlarose
Copy link
Owner Author

Is there a better way to get data sets? Which data sets in particular are we getting via torch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants