Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Suggestion: byeaster #85

Open
meneken17 opened this issue Aug 1, 2020 · 2 comments
Open

Feature Suggestion: byeaster #85

meneken17 opened this issue Aug 1, 2020 · 2 comments

Comments

@meneken17
Copy link

Hey,
I am working on a project which requires christian hollidays. A lot of those are relative to easter sunday.

python-dateutil already supports this extension to the RFC:

byeaster If given, it must be either an integer, or a sequence of integers, positive or negative. Each integer will define an offset from the Easter Sunday. Passing the offset 0 to byeaster will yield the Easter Sunday itself. This is an extension to the RFC specification.

I could try to implemet it myself, but I do not yet understand your code well enough to do this.

@rlanvin
Copy link
Owner

rlanvin commented Aug 10, 2020

Hello, thanks for the suggestion. When I did the port originally I was a bit reluctant to add non-standard extensions such as byeaster, since my intention was to be strict with RFC compliance. However maybe it's time to revisit this decision.

I will leave this ticket open for a bit to gauge if there are more people interested by this feature (please feel free to answer/react).

@meneken17
Copy link
Author

Hey, thanks for the response.
In my opinion this extension would not harm anybody: You can still parse every rfc conform rule and process it.
You will still generare conform rules, unless the user decides to use the "byeaster".
But to find this feature, he has to read some documentation (not just the rfc specs), which will state that the rule is not conform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants