Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP < 7.3 #119

Open
rlanvin opened this issue Sep 30, 2022 · 2 comments
Open

Drop support for PHP < 7.3 #119

rlanvin opened this issue Sep 30, 2022 · 2 comments

Comments

@rlanvin
Copy link
Owner

rlanvin commented Sep 30, 2022

Hello,

I'm considering dropping support for older PHP versions. That would mean increasing the major version number, and a v3 release. But I'm curious, is there anyone still needing this library for PHP < 7.3?

I'll leave this ticket open for some time to collect insights.

@vincenzoraco
Copy link

Hi Rémi, thanks for great dedication on this library. I admire your compassion in checking before making those changes. I'm not affected by removing the support for PHP 7.3, but as a rule of thumb, if there is something that you need to use is available in the next version or you want to use the latest innovation, please update to the next version. If, instead, there is no necessity, you might leave it as it is.

@rlanvin
Copy link
Owner Author

rlanvin commented Jan 5, 2023

Hi @vincenzoraco, I agree and that has been my philosophy so far. The main reason I'm considering dropping some versions now is that it's starting to get difficult to work with PHPUnit. I still need to keep backward compatibility all the way down to PHPUnit 5 (latest version for PHP 5.6). I think in 2022 2023 nobody should be running PHP 5 anymore, so it doesn't seem worth the effort.

I'm less sure about PHP 7 though, maybe some people still rely on 7.1 or 7.2, so I prefer asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants