Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream,agg): support array_agg for streaming mode #4895

Merged
merged 6 commits into from
Aug 25, 2022

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 25, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • SQL commands, functions, and operators

Release note

  • Support array_agg aggregation function

Refer to a related PR or issue link (optional)

#4657

stdrc added 5 commits August 25, 2022 17:24
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc added type/feature component/streaming Stream processing related issue. labels Aug 25, 2022
@stdrc stdrc mentioned this pull request Aug 25, 2022
3 tasks
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #4895 (f0d47ef) into main (aa6aebd) will increase coverage by 0.19%.
The diff coverage is 83.40%.

@@            Coverage Diff             @@
##             main    #4895      +/-   ##
==========================================
+ Coverage   73.80%   74.00%   +0.19%     
==========================================
  Files         871      874       +3     
  Lines      131635   133069    +1434     
==========================================
+ Hits        97148    98472    +1324     
- Misses      34487    34597     +110     
Flag Coverage Δ
rust 74.00% <83.40%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 72.30% <ø> (ø)
src/batch/src/rpc/service/task_service.rs 0.00% <0.00%> (ø)
src/cmd_all/src/playground.rs 0.00% <0.00%> (ø)
src/common/src/util/mod.rs 0.00% <ø> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/connector/src/source/datagen/source/reader.rs 85.30% <ø> (-0.41%) ⬇️
src/expr/src/error.rs 25.00% <0.00%> (-15.00%) ⬇️
src/expr/src/expr/agg.rs 50.00% <0.00%> (ø)
src/expr/src/expr/expr_is_null.rs 90.21% <ø> (ø)
... and 101 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 2cdbb11 into main Aug 25, 2022
@mergify mergify bot deleted the rc/streaming-array-agg branch August 25, 2022 11:42
@hengm3467 hengm3467 added the user-facing-changes Contains changes that are visible to users label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/streaming Stream processing related issue. type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants