Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add support for array_agg in frontend #4717

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 18, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add AggKind::ArrayAgg and necessary match arms.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#4657

stdrc added 2 commits August 18, 2022 15:30
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc added type/feature component/frontend Protocol, parsing, binder. labels Aug 18, 2022
@stdrc stdrc requested review from st1page and TennyZhuang August 18, 2022 07:50
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #4717 (a8b8f8b) into main (1ad9800) will increase coverage by 0.06%.
The diff coverage is 61.82%.

@@            Coverage Diff             @@
##             main    #4717      +/-   ##
==========================================
+ Coverage   73.99%   74.05%   +0.06%     
==========================================
  Files         866      866              
  Lines      130810   130771      -39     
==========================================
+ Hits        96792    96842      +50     
+ Misses      34018    33929      -89     
Flag Coverage Δ
rust 74.05% <61.82%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/join/lookup_join.rs 56.76% <0.00%> (ø)
...c/compute/src/compute_observer/observer_manager.rs 0.00% <0.00%> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/expr/src/expr/agg.rs 50.00% <0.00%> (-4.29%) ⬇️
src/frontend/src/expr/agg_call.rs 59.83% <0.00%> (-2.03%) ⬇️
src/frontend/src/handler/dml.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/query.rs 0.00% <0.00%> (ø)
src/frontend/src/observer/observer_manager.rs 0.00% <0.00%> (ø)
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 85.59% <0.00%> (-0.08%) ⬇️
...rontend/src/scheduler/distributed/query_manager.rs 19.67% <ø> (+10.51%) ⬆️
... and 64 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 4bdedbe into main Aug 18, 2022
@mergify mergify bot deleted the rc/frontend-array-agg branch August 18, 2022 08:36
@stdrc stdrc mentioned this pull request Aug 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/frontend Protocol, parsing, binder. type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants