Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): allow returning error if a rule fails unrecoverably #19381

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 13, 2024

Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#18918, but with minimal code changes.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Bugen Zhao

@stdrc stdrc self-requested a review November 14, 2024 06:05
Signed-off-by: Bugen Zhao <[email protected]>
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao marked this pull request as ready for review November 14, 2024 07:04
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao enabled auto-merge November 14, 2024 08:12
@BugenZhao BugenZhao added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit f89ae89 Nov 19, 2024
28 of 29 checks passed
@BugenZhao BugenZhao deleted the bz/optimizer-apply-error branch November 19, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants