Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump thiserror from 1.0.63 to 2.0.0 #19280

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 6, 2024

Bumps thiserror from 1.0.63 to 2.0.0.

Release notes

Sourced from thiserror's releases.

2.0.0

Breaking changes

  • Referencing keyword-named fields by a raw identifier like {r#type} inside a format string is no longer accepted; simply use the unraw name like {type} (#347)

    This aligns thiserror with the standard library's formatting macros, which gained support for implicit argument capture later than the release of this feature in thiserror 1.x.

    #[derive(Error, Debug)]
    #[error("... {type} ...")]  // Before: {r#type}
    pub struct Error {
        pub r#type: Type,
    }
  • Trait bounds are no longer inferred on fields whose value is shadowed by an explicit named argument in a format message (#345)

    // Before: impl<T: Octal> Display for Error<T>
    // After: impl<T> Display for Error<T>
    #[derive(Error, Debug)]
    #[error("{thing:o}", thing = "...")]
    pub struct Error<T> {
        thing: T,
    }
  • Tuple structs and tuple variants can no longer use numerical {0} {1} access at the same time as supplying extra positional arguments for a format message, as this makes it ambiguous whether the number refers to a tuple field vs a different positional arg (#354)

    #[derive(Error, Debug)]
    #[error("ambiguous: {0} {}", $N)]
    //                  ^^^ Not allowed, use #[error("... {0} {n}", n = $N)]
    pub struct TupleError(i32);
  • Code containing invocations of thiserror's derive(Error) must now have a direct dependency on the thiserror crate regardless of the error data structure's contents (#368, #369, #370, #372)

Features

  • Support disabling thiserror's standard library dependency by disabling the default "std" Cargo feature: thiserror = { version = "2", default-features = false } (#373)

  • Support using r#source as field name to opt out of a field named "source" being treated as an error's Error::source() (#350)

    #[derive(Error, Debug)]
    #[error("{source} ==> {destination}")]
    pub struct Error {
        r#source: char,
        destination: char,

... (truncated)

Commits
  • 6097d61 Release 2.0.0
  • 40113bd Merge pull request #373 from dtolnay/nostd
  • d8ed5fb Allow disabling std dependency on 1.81+
  • 8277ec4 Merge pull request #372 from dtolnay/stdbacktrace
  • d6d896d Access Backtrace exclusively through ::thiserror
  • d14adfb Merge pull request #371 from dtolnay/coreprovider
  • 2e99c51 Drop Provider API support in pre-1.81 nightlies
  • bf3d6f3 Merge pull request #370 from dtolnay/stderror
  • e0e9943 Access Error trait exclusively through ::thiserror
  • db7825e Merge pull request #369 from dtolnay/stdpath
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.63 to 2.0.0.
- [Release notes](https://github.com/dtolnay/thiserror/releases)
- [Commits](dtolnay/thiserror@1.0.63...2.0.0)

---
updated-dependencies:
- dependency-name: thiserror
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner November 6, 2024 18:33
@dependabot dependabot bot requested a review from MrCroxx November 6, 2024 18:33
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 6, 2024
@xxchan xxchan requested a review from BugenZhao November 7, 2024 05:31
@BugenZhao BugenZhao self-assigned this Nov 7, 2024
@graphite-app graphite-app bot requested review from a team November 7, 2024 06:43
@BugenZhao
Copy link
Member

We don't see a compelling reason or benefit to bump the version. Ignore for now.

@dependabot ignore this minor version

@BugenZhao BugenZhao closed this Nov 7, 2024
@dependabot dependabot bot deleted the dependabot/cargo/thiserror-2.0.0 branch November 7, 2024 08:26
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 7, 2024

OK, I won't notify you about version 2.0.x again, unless you re-open this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant