feat(iceberg): reduce iceberg catalog fetch rpc number for iceberg scan #17939
+121
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
reviewed
Dec 17, 2024
Comment on lines
+115
to
+146
| #[derive(Debug, Clone, Eq, PartialEq, Hash, Serialize, Deserialize)] | ||
| pub struct IcebergFileScanTaskJsonStr(String); | ||
|
|
||
| impl IcebergFileScanTaskJsonStr { | ||
| pub fn deserialize(&self) -> FileScanTask { | ||
| serde_json::from_str(&self.0).unwrap() | ||
| } | ||
|
|
||
| pub fn serialize(task: &FileScanTask) -> Self { | ||
| Self(serde_json::to_string(task).unwrap()) | ||
| } | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Eq, PartialEq, Hash, Serialize, Deserialize)] | ||
| pub struct TableMetadataJsonStr(String); | ||
|
|
||
| impl TableMetadataJsonStr { | ||
| pub fn deserialize(&self) -> TableMetadata { | ||
| serde_json::from_str(&self.0).unwrap() | ||
| } | ||
|
|
||
| pub fn serialize(metadata: &TableMetadata) -> Self { | ||
| Self(serde_json::to_string(metadata).unwrap()) | ||
| } | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Eq, PartialEq, Hash, Serialize, Deserialize)] | ||
| pub struct IcebergSplit { | ||
| pub split_id: i64, | ||
| pub snapshot_id: i64, | ||
| pub files: Vec<String>, | ||
| pub table_meta: TableMetadataJsonStr, | ||
| pub files: Vec<IcebergFileScanTaskJsonStr>, |
There was a problem hiding this comment.
Why do we want to serialize them as JSON str, instead of serialize directly?
BTW, for serializing as JSON str, a better way is to #[serde_as(as = "JsonString")] https://docs.rs/serde_with/latest/serde_with/json/struct.JsonString.html
(So we still have deserialized representation in memory)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.