fix(source): cleanup unused key schema logic & requirements for format upsert encode avro
#17759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabVersion
approved these changes
Jul 22, 2024
Comment on lines
-87
to
-96
| statement error SCHEMA_REGISTRY_NAME_STRATEGY_TOPIC_RECORD_NAME_STRATEGY expect non-empty field key\.message | ||
| create table t_topic_record () with ( | ||
| connector = 'kafka', | ||
| topic = 'upsert_avro_json-topic-record', | ||
| properties.bootstrap.server = '${RISEDEV_KAFKA_BOOTSTRAP_SERVERS}' | ||
| ) format upsert encode avro ( | ||
| schema.registry = '${RISEDEV_SCHEMA_REGISTRY_URL}', | ||
| schema.registry.name.strategy = 'topic_record_name_strategy', | ||
| message = 'CPLM.OBJ_ATTRIBUTE_VALUE' | ||
| ); |
There was a problem hiding this comment.
it makes sense removing name strategy related things since we does not interpret key schema.
Hmmm, for |
I have not followed the whole debezium path yet, so I cannot tell whether those lines are useful or not. |
xiangjinwu
added
the
user-facing-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolves #17670
AvroProperties::enable_upsertis not usefulAvroParserConfig::key_schemais alwaysNone(after boolean removal above)encoding_typeis always hardcoded asEncodingType::Valueexcept for DebeziumAvro.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.