refactor(optimizer): unify watermark derivation and monotonicity derivation #17554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdrc
commented
Jul 3, 2024
Comment on lines
159
to
247
| ExprType::AtTimeZone => match self.visit_binary_op(func_call.inputs()) { | ||
| (Constant, Constant) => Constant, | ||
| (any, Constant) => { | ||
| let time_zone = func_call.inputs()[1] | ||
| .as_literal() | ||
| .and_then(|literal| literal.get_data().as_ref()) | ||
| .map(|tz| tz.as_utf8().as_ref()); | ||
| // 1. For at_time_zone(timestamp, const timezone) -> timestamptz, when timestamp has some monotonicity, | ||
| // the result should have the same monotonicity. | ||
| // 2. For at_time_zone(timestamptz, const timezone) -> timestamp, when timestamptz has some monotonicity, | ||
| // the result only have the same monotonicity when the timezone is without DST (Daylight Saving Time). | ||
| if (func_call.inputs()[0].return_type() == DataType::Timestamp | ||
| && func_call.return_type() == DataType::Timestamptz) | ||
| || time_zone_is_without_dst(time_zone) | ||
| { | ||
| any | ||
| } else { | ||
| Unknown | ||
| } | ||
| } | ||
| _ => Unknown, | ||
| }, | ||
| ExprType::DateTrunc => match func_call.inputs().len() { | ||
| 2 => match self.visit_binary_op(func_call.inputs()) { | ||
| (Constant, any) => any, | ||
| _ => Unknown, | ||
| }, | ||
| 3 => match self.visit_ternary_op(func_call.inputs()) { | ||
| (Constant, Constant, Constant) => Constant, | ||
| (Constant, any, Constant) => { | ||
| let time_zone = func_call.inputs()[2] | ||
| .as_literal() | ||
| .and_then(|literal| literal.get_data().as_ref()) | ||
| .map(|tz| tz.as_utf8().as_ref()); | ||
| if time_zone_is_without_dst(time_zone) { | ||
| any | ||
| } else { | ||
| Unknown | ||
| } | ||
| } | ||
| _ => Unknown, | ||
| }, | ||
| _ => unreachable!(), | ||
| }, | ||
| ExprType::AddWithTimeZone | ExprType::SubtractWithTimeZone => { | ||
| // Requires time zone and interval to be literal, at least for now. | ||
| let time_zone = match &func_call.inputs()[2] { | ||
| ExprImpl::Literal(lit) => { | ||
| lit.get_data().as_ref().map(|tz| tz.as_utf8().as_ref()) | ||
| } | ||
| _ => return Unknown, | ||
| }; | ||
| let interval = match &func_call.inputs()[1] { | ||
| ExprImpl::Literal(lit) => lit | ||
| .get_data() | ||
| .as_ref() | ||
| .map(|interval| interval.as_interval()), | ||
| _ => return Unknown, | ||
| }; | ||
| let quantitative_only = interval.map_or( | ||
| true, // null interval is treated as `interval '1' second` | ||
| |v| v.months() == 0 && (v.days() == 0 || time_zone_is_without_dst(time_zone)), | ||
| ); | ||
| match (self.visit_expr(&func_call.inputs()[0]), quantitative_only) { |
There was a problem hiding this comment.
Small fixes related to these datetime functions are included when adapting the old WatermarkAnalyzer code to the new MonotonicityAnalyzer. PTAL cc @xiangjinwu
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/column-monotonicity
branch
from
9f264c4 to
6b9feea
Compare
st1page
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously we have
Nondecreasingvariant ofWatermarkDerivationto support watermark onproctimecolumn;When I worked on the continuation of the "monotonicity" property, I realized that we can unify the watermark and monotonicity derivation process, by
WatermarkDerivationin the same recursive manner as we do forWatermarkDerivation;WatermarkDerivation.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.