fix(sink): fix sink in to Cassandra failed when using column name containing upper case letter #17493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you help add some test to cover this case? |
xxhZs
force-pushed
the
xxh/fix-cassandra-column_name
branch
from
e4143c8 to
a00f692
Compare
xxhZs
force-pushed
the
xxh/fix-cassandra-column_name
branch
from
7693be2 to
acf7086
Compare
xxhZs
force-pushed
the
xxh/fix-cassandra-column_name
branch
from
acf7086 to
ef1cf1a
Compare
xiangjinwu
reviewed
Jul 2, 2024
...tor-node/risingwave-sink-cassandra/src/main/java/com/risingwave/connector/CassandraSink.java
Show resolved
Hide resolved
We have checked, and the reason for this bug is that the Rw and Cassandra names are completely consistent, but our CQL statement concatenation is incorrect |
xxchan
reviewed
Jul 26, 2024
xxhZs
force-pushed
the
xxh/fix-cassandra-column_name
branch
from
53393b8 to
3e570d8
Compare
xxhZs
force-pushed
the
xxh/fix-cassandra-column_name
branch
from
3e570d8 to
b5cfeb7
Compare
kwannoel
reviewed
Jul 30, 2024
xxhZs
force-pushed
the
xxh/fix-cassandra-column_name
branch
from
ee5f887 to
887a6c5
Compare
fix fix
xxhZs
force-pushed
the
xxh/fix-cassandra-column_name
branch
from
887a6c5 to
ef71d85
Compare
lmatz
added
the
need-cherry-pick-release-1.10
lmatz
approved these changes
Aug 20, 2024
xxchan
reviewed
Aug 20, 2024
Comment on lines
65
to
73
| if cat ./query_result2.csv | awk -F "," '{ | ||
| exit !($1 == 1 && $2 == 1 && $3 == "1\r"); }'; then | ||
| echo "Cassandra sink check passed" | ||
| else | ||
| echo "The output is not as expected." | ||
| echo "output:" | ||
| cat ./query_result2.csv | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
nit: I think we can also put the validation logic in cassandra_sink.slt using system command
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…taining upper case letter (#17493)
This was referenced Aug 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…taining upper case letter (#17493) (#18126) Co-authored-by: Xinhao Xu <[email protected]>
lmatz
pushed a commit
that referenced
this pull request
Sep 24, 2024
…taining upper case letter (#17493)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#17490
#17855
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.