feat(optimizer): grow stack for complicated plan in more places #17224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Follow-up of #16279. Based on some actual queries provided by users, this PR adopts fearless recursion to more places to provide better support for complicated plan in optimizer, including:
The theory behind why this will work by only touching the optimizer code may be that, the final physical plan and expression tree executed on the compute nodes could be less complex than what we have to handle in the optimizer, thus requiring less stack depth. This is further because...
However, this still cannot cover those most complicated queries, which will overflows the stack even when calling the compiler-generated
Clone
impl. The only workaround is to setRUST_STACK_SIZE
in that case.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.