From f7eb9083b9c2b68d0f9e57079fd43a1cc2297999 Mon Sep 17 00:00:00 2001 From: Jinser Kafka Date: Thu, 16 May 2024 18:23:02 +0800 Subject: [PATCH 1/2] fix: remove unused `r#type` field in GooglePubSubConfig --- src/connector/src/sink/google_pubsub.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/connector/src/sink/google_pubsub.rs b/src/connector/src/sink/google_pubsub.rs index 6fffbc50570fa..392d7cd0f1e48 100644 --- a/src/connector/src/sink/google_pubsub.rs +++ b/src/connector/src/sink/google_pubsub.rs @@ -70,9 +70,6 @@ pub struct GooglePubSubConfig { /// `pubsub.publisher` [role](https://cloud.google.com/pubsub/docs/access-control#roles) #[serde(rename = "pubsub.credentials")] pub credentials: Option, - - // accept "append-only" - pub r#type: String, } impl GooglePubSubConfig { From f2cc5f505697a77e87306aac79a63be268bff7c6 Mon Sep 17 00:00:00 2001 From: Jinser Kafka Date: Fri, 17 May 2024 12:52:37 +0800 Subject: [PATCH 2/2] rerun `./risedev generate-with-options` --- src/connector/with_options_sink.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/connector/with_options_sink.yaml b/src/connector/with_options_sink.yaml index 3dbe5d394a8e8..a38a92f4e356c 100644 --- a/src/connector/with_options_sink.yaml +++ b/src/connector/with_options_sink.yaml @@ -152,9 +152,6 @@ GooglePubSubConfig: field_type: String comments: A JSON string containing the service account credentials for authorization, see the [service-account](https://developers.google.com/workspace/guides/create-credentials#create_credentials_for_a_service_account) credentials guide. The provided account credential must have the `pubsub.publisher` [role](https://cloud.google.com/pubsub/docs/access-control#roles) required: false - - name: r#type - field_type: String - required: true IcebergConfig: fields: - name: connector